Pin the Hex packages' versions at publish time - #45
Merged
Merged
Conversation
Each published mix.exs read its version from the compiling machine's environment: GAMEND_CONTENT_APP_VERSION for gamend_core/gamend_web, APP_VERSION for gamend_sdk/gamend_plugin_tools. A host Dockerfile that exported GAMEND_CONTENT_APP_VERSION=1.0.0 compiled the engine as 1.0.0, and the SDK pair, whose @Version was never stamped, compiled as 1.0.26 without APP_VERSION. Both failed a host's ">= 1.0.1266" requirement. A step before the first publish now stamps @Version in all four files and replaces the env lookup with @Version, failing if either edit does not land. The repo's own Docker image and docs job are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin each Hex package's version in its mix.exs at publish time, so hosts no longer compile gamend_core/gamend_web/gamend_sdk/gamend_plugin_tools as whatever GAMEND_CONTENT_APP_VERSION or APP_VERSION holds (1.0.0, 1.0.26).